Google Git
Sign in
android-kvm / kvmtool / 13ea439a1f48a19cc31e5c39abb8079aa8deedef
commit13ea439a1f48a19cc31e5c39abb8079aa8deedef[log] [tgz]
authorJean-Philippe Brucker <jean-philippe@linaro.org>Tue Jun 06 14:04:18 2023 +0100
committerWill Deacon <will@kernel.org>Thu Jun 08 22:39:03 2023 +0100
tree08903e662473bcb1c0253647e763e44089d2f710
parentb8420e8d5d8dd74c7efd86d4ed7df724127fe184 [diff]
virtio/scsi: Fix feature selection

We should advertise to the guest only the features supported by vhost
and kvmtool. Then we should set in vhost only the features acked by the
guest. Move vhost feature query to get_host_features(), and vhost
feature setting to device start (after the guest has acked features).

This fixes scsi because we used to enable all vhost features including
VIRTIO_SCSI_F_T10_PI which changes the request layout and caused
inconsistency between guest and vhost.

Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Link: https://lore.kernel.org/r/20230606130426.978945-10-jean-philippe@linaro.org
Signed-off-by: Will Deacon <will@kernel.org>
1 file changed
tree: 08903e662473bcb1c0253647e763e44089d2f710
  1. arm/
  2. config/
  3. disk/
  4. Documentation/
  5. guest/
  6. hw/
  7. include/
  8. mips/
  9. net/
  10. powerpc/
  11. riscv/
  12. tests/
  13. ui/
  14. util/
  15. vfio/
  16. virtio/
  17. x86/
  18. .gitignore
  19. builtin-balloon.c
  20. builtin-debug.c
  21. builtin-help.c
  22. builtin-list.c
  23. builtin-pause.c
  24. builtin-resume.c
  25. builtin-run.c
  26. builtin-sandbox.c
  27. builtin-setup.c
  28. builtin-stat.c
  29. builtin-stop.c
  30. builtin-version.c
  31. code16gcc.h
  32. COPYING
  33. CREDITS-Git
  34. devices.c
  35. framebuffer.c
  36. guest_compat.c
  37. INSTALL
  38. ioeventfd.c
  39. irq.c
  40. kvm-cmd.c
  41. kvm-cpu.c
  42. kvm-ipc.c
  43. kvm.c
  44. main.c
  45. Makefile
  46. mmio.c
  47. pci.c
  48. README
  49. symbol.c
  50. term.c