tree 4e70660cf19da3a266603b76c5031cbc02bc09a5
parent e554aefd04bd38a8b6e9040022d494e5b7ae7a59
author Andre Przywara <andre.przywara@arm.com> 1587663520 +0100
committer Will Deacon <will@kernel.org> 1587747529 +0100

virtio-mmio: Assign IRQ line directly before registering device

At the moment the IRQ line for a virtio-mmio device is assigned in the
generic device__register() routine in devices.c, by calling back into
virtio-mmio.c. This does not only sound slightly convoluted, but also
breaks when we try to register an MMIO device that is not a virtio-mmio
device. In this case container_of will return a bogus pointer (as it
assumes a struct virtio_mmio), and the IRQ allocation routine will
corrupt some data in the device_header (for instance the first byte
of the "data" pointer).

Simply assign the IRQ directly in virtio_mmio_init(), before calling
device__register(). This avoids the problem and looks actually much more
straightforward.

Tested-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Will Deacon <will@kernel.org>