| commit | 07f8230b4b39b8b7fb401a67f308c61a43542402 | [log] [tgz] |
|---|---|---|
| author | Justin Stitt <justinstitt@google.com> | Tue Apr 02 20:39:49 2024 +0000 |
| committer | Kees Cook <keescook@chromium.org> | Tue Apr 30 10:34:29 2024 -0700 |
| tree | 761d9094a12371ac60e63144e7acb8f7db557fa1 | |
| parent | 998b18072ceb0613629c256b409f4d299829c7ec [diff] |
init: replace deprecated strncpy with strscpy_pad strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. data_page wants to be NUL-terminated and NUL-padded, use strscpy_pad to provide both of these. data_page no longer awkwardly relies on init_mount to perform its NUL-termination, although that sanity check is left unchanged. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: <linux-hardening@vger.kernel.org> Signed-off-by: Justin Stitt <justinstitt@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20240402-strncpy-init-do_mounts-c-v1-1-e16d7bc20974@google.com Signed-off-by: Kees Cook <keescook@chromium.org>