tree 88fa899b8a1afdf75f87aa0123590884049a571f
parent 6532582c353f4c83e3ccdd7255020ab852b90b0b
author Michael Walle <michael@walle.cc> 1636619833 +0100
committer Mark Brown <broonie@kernel.org> 1636741083 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGOr9sACgkQJNaLcl1U
 h9BGnAf7B3ytK9uaqWOgkGBuzm0hMF8AfL5Q8taXbZJuW8jW/Ihpxi5FDBKvA8v2
 +0dmt3cd0+KFk5ysa6yabhLx7M28Y1Amwj9cE4GTcqtoBGfoESnB0TKiEya9A3Mc
 blUMhtRNF4XBTRO6Ijfz7i81urVG3rfsKSIQfcjv5QB+yyD6aKIt+Gju8svcyGga
 TaCmJptYSEWcKiWv59HvurcQ21x8Yd/zjzL2+bwJ/uEzoUx4g1WAdExkyWg41mb2
 HSDxGEYdIhKhfVfTqXPoh1m9ipBzDSDbWZCA/QPoR06u26u66b1fMblGiJfZF/Rv
 ixAOkQ2XQ7d/sl+jjA0J+jVEYWT36g==
 =dRuH
 -----END PGP SIGNATURE-----

spi: fix use-after-free of the add_lock mutex

Commit 6098475d4cb4 ("spi: Fix deadlock when adding SPI controllers on
SPI buses") introduced a per-controller mutex. But mutex_unlock() of
said lock is called after the controller is already freed:

  spi_unregister_controller(ctlr)
  -> put_device(&ctlr->dev)
    -> spi_controller_release(dev)
  -> mutex_unlock(&ctrl->add_lock)

Move the put_device() after the mutex_unlock().

Fixes: 6098475d4cb4 ("spi: Fix deadlock when adding SPI controllers on SPI buses")
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org # v5.15
Link: https://lore.kernel.org/r/20211111083713.3335171-1-michael@walle.cc
Signed-off-by: Mark Brown <broonie@kernel.org>