commit 0823b2c3c10a4db21cd39a8c72cda96b4dd6d914
author Andrea Merello <andreamrl@tiscali.it> Sat May 10 13:30:12 2008 +0200
committer John W. Linville <linville@tuxdriver.com> Wed May 28 16:43:38 2008 -0400
tree b53f61039d2bf7c6e1ba3ca0ad40ed949aed29e6
parent 6f6c218f68e632e4596cae6e6d43658d26a5e0fe

rtl8180: fix wrong parameter in sa2400_rf_set_channel

The sa2400 RF code needs to invoke sa2400_write_phy_antenna every time the
channel is being switch.

This should be done passing the channel number to that function.
Incorrectly we were passing the same value that is written on the
channel RF register.
This may cause problems when operating on ch 14.

This patch fixes it.

Thanks to Alessandro Di Marco who found this issue!

Signed-off-by: Andrea Merello <andreamrl@tiscali.it>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

drivers/net/wireless/rtl8180_sa2400.c

diff --git a/drivers/net/wireless/rtl8180_sa2400.c b/drivers/net/wireless/rtl8180_sa2400.c
index 0311b4e..cea4e0c 100644
--- a/drivers/net/wireless/rtl8180_sa2400.c
+++ b/drivers/net/wireless/rtl8180_sa2400.c
@@ -86,7 +86,7 @@
 
 	write_sa2400(dev, 7, txpw);
 
-	sa2400_write_phy_antenna(dev, chan);
+	sa2400_write_phy_antenna(dev, channel);
 
 	write_sa2400(dev, 0, chan);
 	write_sa2400(dev, 1, 0xbb50);