commit 0c87b1ac604518a0d3f527080c6883d5c2402fb4
author Jiapeng Zhong <abaci-bugfix@linux.alibaba.com> Mon Jan 25 14:41:46 2021 +0800
committer Steffen Klassert <steffen.klassert@secunet.com> Wed Jan 27 11:49:55 2021 +0100
tree 0e002bd1f9036dcc1d985ab51b8af17f553d6804
parent 18f976960bca0c32c5a072a2e003a99c156268bc

net: Simplify the calculation of variables

Fix the following coccicheck warnings:

 ./net/ipv4/esp4_offload.c:288:32-34: WARNING !A || A && B is
equivalent to !A || B.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

net/ipv4/esp4_offload.c

diff --git a/net/ipv4/esp4_offload.c b/net/ipv4/esp4_offload.c
index 5bda5ae..601f5fb 100644
--- a/net/ipv4/esp4_offload.c
+++ b/net/ipv4/esp4_offload.c
@@ -285,7 +285,7 @@ static int esp_xmit(struct xfrm_state *x, struct sk_buff *skb,  netdev_features_
 	esp.esph = ip_esp_hdr(skb);
 
 
-	if (!hw_offload || (hw_offload && !skb_is_gso(skb))) {
+	if (!hw_offload || !skb_is_gso(skb)) {
 		esp.nfrags = esp_output_head(x, skb, &esp);
 		if (esp.nfrags < 0)
 			return esp.nfrags;