commit 0d7cd09a3dbbdb3d4932cddbef613b2a6de28b75
author Kees Cook <keescook@chromium.org> Fri Mar 03 12:11:40 2017 -0800
committer Kees Cook <keescook@chromium.org> Tue Mar 07 08:21:38 2017 -0800
tree 7b0b2975a3640de807561f1091476a6c08cd90ee
parent 1344dd86f35c7669c94aceb2273676e356cff848

pstore: Improve register_pstore() error reporting

Uncommon errors are better to get reported to dmesg so developers can
more easily figure out why pstore is unhappy with a backend attempting
to register.

Signed-off-by: Kees Cook <keescook@chromium.org>

fs/pstore/platform.c

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index d69ef8a..320a673 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -673,11 +673,15 @@ int pstore_register(struct pstore_info *psi)
 {
 	struct module *owner = psi->owner;
 
-	if (backend && strcmp(backend, psi->name))
+	if (backend && strcmp(backend, psi->name)) {
+		pr_warn("ignoring unexpected backend '%s'\n", psi->name);
 		return -EPERM;
+	}
 
 	spin_lock(&pstore_lock);
 	if (psinfo) {
+		pr_warn("backend '%s' already loaded: ignoring '%s'\n",
+			psinfo->name, psi->name);
 		spin_unlock(&pstore_lock);
 		return -EBUSY;
 	}