commit 12f0258d5b44b3b5a9442ec461bbac1f7edab8c6
author Dan Carpenter <error27@gmail.com> Sat Mar 19 08:44:34 2011 +0300
committer Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Thu Mar 24 10:32:44 2011 -0400
tree 9dbaf66cde561ec613e5bd838a7a52642c3b1ae4
parent 804f18536984939622ddca60ab6b25743e0ec68d

xen-gntdev: return -EFAULT on copy_to_user failure

copy_to_user() returns the amount of data remaining to be copied.  We
want to return a negative error code here.  The upper layers just
call WARN_ON() if we return non-zero so this doesn't change the
behavior.  But returning -EFAULT is still cleaner.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

drivers/xen/gntdev.c

diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index 017ce60..00b3acc 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -273,7 +273,7 @@
 				map->vma->vm_start + map->notify.addr;
 			err = copy_to_user(tmp, &err, 1);
 			if (err)
-				return err;
+				return -EFAULT;
 			map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE;
 		} else if (pgno >= offset && pgno < offset + pages) {
 			uint8_t *tmp = kmap(map->pages[pgno]);