tree ef1da81e54aa5c3b482ac48b9eb0a9491a803b0e
parent 5afc7eefe41645259da84898fc55f6f46cb4de47
author Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> 1676564620 +0200
committer Mark Brown <broonie@kernel.org> 1676565075 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPuWlMACgkQJNaLcl1U
 h9AwTAf/fa1wRob+1pAE6425bufh8Sh4LhbK4FWaCJv/FgebeP08UkfTgOE4XiU/
 eRsA4f23+suRqtemAFcOi4wA0hgcsG00jwDjig9QvJaypvljgF3it1g2rlFkIJTD
 tQQ16xf4Np4fIlX5exZUeUCE/MaVkZQTtfx89h5qvtVDoyPOpum6371JSxJOQsvW
 N+KiWAG7b7KPG7j7AeFOFQ4FiwzfPF+2rA5qeZk7aDdQTntjeIf9ACqsXxKbDLbQ
 Syi7Y/81T0RwNd9YHF9NhSheX5ExKqtxu1Yw8xjte4FgY9UhYZX1cdGvBfrVHDTO
 Fwz/WFMMYqPZ6vJldG5IzwR+igoZsg==
 =hvp0
 -----END PGP SIGNATURE-----

ASoC: SOF: Intel: hda-dai: fix possible stream_tag leak

The HDaudio stream allocation is done first, and in a second step the
LOSIDV parameter is programmed for the multi-link used by a codec.

This leads to a possible stream_tag leak, e.g. if a DisplayAudio link
is not used. This would happen when a non-Intel graphics card is used
and userspace unconditionally uses the Intel Display Audio PCMs without
checking if they are connected to a receiver with jack controls.

We should first check that there is a valid multi-link entry to
configure before allocating a stream_tag. This change aligns the
dma_assign and dma_cleanup phases.

Complements: b0cd60f3e9f5 ("ALSA/ASoC: hda: clarify bus_get_link() and bus_link_get() helpers")
Link: https://github.com/thesofproject/linux/issues/4151
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230216162340.19480-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>