tree 1408cdb798aacbb27a42fe735b6658289c6004ec
parent 8bfdfbc188ff46f7495ae05a2bc366943b83393f
author Mathias Krause <minipli@googlemail.com> 1393015114 +0100
committer David S. Miller <davem@davemloft.net> 1393286065 -0500

pktgen: fix out-of-bounds access in pgctrl_write()

If a privileged user writes an empty string to /proc/net/pktgen/pgctrl
the code for stripping the (then non-existent) '\n' actually writes the
zero byte at index -1 of data[]. The then still uninitialized array will
very likely fail the command matching tests and the pr_warning() at the
end will therefore leak stack bytes to the kernel log.

Fix those issues by simply ensuring we're passed a non-empty string as
the user API apparently expects a trailing '\n' for all commands.

Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>