tree 98571c4c496c626303359d2de00210638abfac8f
parent 85ab6fdf3791c68aa7b8eb484f68855b8a6b9884
author Erick Archer <erick.archer@gmx.com> 1705758840 +0100
committer Palmer Dabbelt <palmer@rivosinc.com> 1710950167 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQJHBAABCAAxFiEEKzw3R0RoQ7JKlDp6LhMZ81+7GIkFAmX7BxcTHHBhbG1lckBk
 YWJiZWx0LmNvbQAKCRAuExnzX7sYiW0pD/95qHVzhH44gZAHaXWrrzw6qVFxSw12
 KHBDdBWhut8sJy6D59ufFdcmkeJdcpDWtYSSp+zUtmaEQa2wDmcFspx5W2KRoQ28
 nW+kGpLM7TMAS5z4vVz4r5jA0O/X/aqVCn4C2sqdlnO6tBJGRHcV8KZP9yLLMHx5
 7PO99jnQ2A8yNxy59ZjiHpUqDefraN7pbm2gN5/R8KdvBaFjZuv/uIzSIcLlK5vM
 WdBkc4Kf9ZUzehj79K4XjJKLzdI+2qNYFq4DIz4cm/zVDdjcxscUulGIeUGTTPQB
 nt2Re2X05riaT54pIxPHASF598q6FK0yIx71QOuyhRrIGCRaJRcfN5/+VMdR1hcV
 Srt4gcg5gv6Mx3SQDr6uLmBKZSYUY9JNfW7RJByuhhhwlw70ujdmiHG2IX34sKK5
 SGh3HTPoBa1v2w+3uWoivz9anTUR0sae1dEO3SkUdPrJWpb3/ymKq4ZOdCp1KIWe
 znfbrQuGjwCEsTyFggoaSpJIFDUdPYdGGAt9+Gb4tdjNCx38+QvCLcPLqatstAu4
 QVMzdAJ1Miij/0mi3gP4Vy7suFl2Fd1Ocf/tsPstX6k8uID3foaCthfN/YRPGhKB
 PlgKthOcu3O/k2XLaY53YzDYjusH/55ZDAULcVH9Sb26RIUmcumqw+EGL2d6BGkr
 eg9kQb4nSu8Ybw==
 =PpiR
 -----END PGP SIGNATURE-----

riscv: Use kcalloc() instead of kzalloc()

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
count * size in the kzalloc() function.

Also, it is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not change the
former (unlike the latter).

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1]
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20240120135400.4710-1-erick.archer@gmx.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>