commit 2eeaf0bbca79412f15d00a08b930cbd9235fc3a2
author Greg Kroah-Hartman <gregkh@linuxfoundation.org> Thu Apr 30 11:22:05 2015 +0200
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> Sun May 10 19:04:16 2015 +0200
tree 8e4cf5adaee137a054bf3dd4a3bd1c4875c1cc5e
parent ed334c0e3b4def138a27c84d7331c304f87a4701

tty: amiserial.c: move assignment out of if () block

We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

CC: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/tty/amiserial.c

diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 894d3a8..e53d9a5 100644
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -1782,7 +1782,8 @@
 	struct serial_state *state = platform_get_drvdata(pdev);
 
 	/* printk("Unloading %s: version %s\n", serial_name, serial_version); */
-	if ((error = tty_unregister_driver(serial_driver)))
+	error = tty_unregister_driver(serial_driver);
+	if (error)
 		printk("SERIAL: failed to unregister serial driver (%d)\n",
 		       error);
 	put_tty_driver(serial_driver);