tree 25e96b0e412a412ba30e4af811d3934d462ea13f
parent 6650ab2a44268af8d24995d28ae199b57b2ebff8
author Pratyush Yadav <p.yadav@ti.com> 1610129697 +0530
committer Mark Brown <broonie@kernel.org> 1610382170 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/8e1oACgkQJNaLcl1U
 h9CRhwf/d952DGOESeROCH8CxdgXFuARAzSaPjjeqrxzAdF7ilNXtzh73JGZJ7X+
 kMotinAah80kCIPCMZnxYavIZVH38agwMqYRtU9D9yfN2+ZHYLLUY8lKX/S30CUH
 eJN1ZpBqnfHmkTqrNQDfesWgM7c2M01xeG09VNWM5+I3ZDl+VYQscOY3af/QFhge
 jeHfwyCquuOGDrKeVIF1iMPQAZ1+EncI6F9eXpvc9v8HwcnC9aLHU2WXeZVxCd0V
 etjoKm6LIaaL/aza++EXGQs++HnPxdPbB/96NynjyTEi4IfdjqnIuYgAYJHbOKIL
 AQsSMa0tW1ik9Agmml95S5LkoELg6g==
 =C9gT
 -----END PGP SIGNATURE-----

spi: cadence-quadspi: Fix build warning on 32-bit platforms

The kernel test robot reports the following warning.

drivers/spi/spi-cadence-quadspi.c:966:24: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'unsigned int *') and 'typeof (500UL) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types]
                                            msecs_to_jiffies(max(len, 500UL)))) {
                                                             ^~~~~~~~~~~~~~~
   include/linux/minmax.h:58:19: note: expanded from macro 'max'
   #define max(x, y)       __careful_cmp(x, y, >)
                           ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/minmax.h:42:24: note: expanded from macro '__careful_cmp'
           __builtin_choose_expr(__safe_cmp(x, y), \
                                 ^~~~~~~~~~~~~~~~
   include/linux/minmax.h:32:4: note: expanded from macro '__safe_cmp'
                   (__typecheck(x, y) && __no_side_effects(x, y))
                    ^~~~~~~~~~~~~~~~~
   include/linux/minmax.h:18:28: note: expanded from macro '__typecheck'
           (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
                      ~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~
   1 warning generated.

This happens because size_t is unsigned long on 64-bit platforms like
arm64 but it is unsigned int on 32-bit platforms like arm. Omitting the
"UL" would result in a warning on 64-bit platforms. Squash it by type
casting the arguments to size_t using max_t(). This way builds on both
type of platforms can be satisfied. There is no chance of any truncation
since 500 is small enough to fit into both int and long.

Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Link: https://lore.kernel.org/r/20210108181457.30291-1-p.yadav@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>