tree cd81852109bbf82a77ff54de1f00d61408c3d920
parent ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc
author Al Viro <viro@zeniv.linux.org.uk> 1421642252 -0500
committer Al Viro <viro@zeniv.linux.org.uk> 1421642966 -0500

fix deadlock in cifs_ioctl_clone()

It really needs to check that src is non-directory *and* use
{un,}lock_two_nodirectories().  As it is, it's trivial to cause
double-lock (ioctl(fd, CIFS_IOC_COPYCHUNK_FILE, fd)) and if the
last argument is an fd of directory, we are asking for trouble
by violating the locking order - all directories go before all
non-directories.  If the last argument is an fd of parent
directory, it has 50% odds of locking child before parent,
which will cause AB-BA deadlock if we race with unlink().

Cc: stable@vger.kernel.org @ 3.13+
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>