commit 4103369093df0e2ccc295ad08a3077b72aed0ccb
author Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Thu Mar 25 09:39:56 2021 +0100
committer Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Fri Apr 09 13:05:43 2021 +0200
tree ff83ba86b038ec33b2a65a39e7cdc8163d9ff14c
parent be8cd6cccf0e3d42f61040bc341ac92a9adde08b

media: mxl692: remove impossible condition

Fix the following coverity warning:

This greater-than-or-equal-to-zero comparison of an unsigned value is
always true. "opcode >= 0".

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

drivers/media/dvb-frontends/mxl692.c

diff --git a/drivers/media/dvb-frontends/mxl692.c b/drivers/media/dvb-frontends/mxl692.c
index 86af831..8303064 100644
--- a/drivers/media/dvb-frontends/mxl692.c
+++ b/drivers/media/dvb-frontends/mxl692.c
@@ -377,7 +377,7 @@ static int mxl692_memread(struct mxl692_dev *dev, u32 addr,
 
 static const char *mxl692_opcode_string(u8 opcode)
 {
-	if (opcode >= 0 && opcode <= MXL_EAGLE_OPCODE_INTERNAL)
+	if (opcode <= MXL_EAGLE_OPCODE_INTERNAL)
 		return MXL_EAGLE_OPCODE_STRING[opcode];
 
 	return "invalid opcode";