commit 46578a6913e6f5e69229561736b94c18c2e88ae4
author Roel Kluin <roel.kluin@gmail.com> Mon Feb 02 21:39:02 2009 -0800
committer David S. Miller <davem@davemloft.net> Mon Feb 02 21:39:02 2009 -0800
tree 23db22f32e094dd971650528ea1d499bd2ab3015
parent 0047e5d240ede4e84c03bc9001375175900fd259

net: variables reach -1, but 0 tested

while (timeout--) { ... }

timeout becomes -1 if the loop isn't ended otherwise, not 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/net/tsi108_eth.c

diff --git a/drivers/net/tsi108_eth.c b/drivers/net/tsi108_eth.c
index 75461db..a9fd2b2 100644
--- a/drivers/net/tsi108_eth.c
+++ b/drivers/net/tsi108_eth.c
@@ -1237,7 +1237,7 @@
 	spin_lock_irqsave(&phy_lock, flags);
 
 	tsi108_write_mii(data, MII_BMCR, BMCR_RESET);
-	while (i--){
+	while (--i) {
 		if(!(tsi108_read_mii(data, MII_BMCR) & BMCR_RESET))
 			break;
 		udelay(10);