commit 5112e9a540fb4a63184850c6570f30ae13b5f5e3
author Harshad Shirwadkar <harshadshirwadkar@gmail.com> Fri Oct 23 09:13:39 2020 -0700
committer Theodore Ts'o <tytso@mit.edu> Wed Oct 28 13:41:16 2020 -0400
tree f80ab6f1285ab29c913fd4fa29307f649bbeadca
parent 96485e4462604744d66bf4301557d996d80b85eb

ext4: fix double locking in ext4_fc_commit_dentry_updates()

Fixed double locking of sbi->s_fc_lock in the above function
as reported by kernel-test-robot.

Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20201023161339.1449437-1-harshadshirwadkar@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

fs/ext4/fast_commit.c

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 447c8d9..1d72f8f 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -964,7 +964,6 @@ static int ext4_fc_commit_dentry_updates(journal_t *journal, u32 *crc)
 			fc_dentry->fcd_parent, fc_dentry->fcd_ino,
 			fc_dentry->fcd_name.len,
 			fc_dentry->fcd_name.name, crc)) {
-			spin_lock(&sbi->s_fc_lock);
 			ret = -ENOSPC;
 			goto lock_and_exit;
 		}