commit 517ccc2aa50dbd7767a9eb8e1d9987a3ed7ced3e
author Kangjie Lu <kjlu@umn.edu> Sat Mar 16 16:46:05 2019 -0500
committer David S. Miller <davem@davemloft.net> Sat Mar 16 18:19:49 2019 -0700
tree beff239c4d9e8105e6f547b3e9f2d2de2a5d7eaf
parent 9180bb4f046064dfa4541488102703b402bb04e1

net: tipc: fix a missing check for nla_nest_start

nla_nest_start may fail. The fix check its status and returns
-EMSGSIZE in case it fails.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/tipc/socket.c

diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 3274ef6..d6b2686 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -3255,6 +3255,8 @@ static int __tipc_nl_add_sk_con(struct sk_buff *skb, struct tipc_sock *tsk)
 	peer_port = tsk_peer_port(tsk);
 
 	nest = nla_nest_start(skb, TIPC_NLA_SOCK_CON);
+	if (!nest)
+		return -EMSGSIZE;
 
 	if (nla_put_u32(skb, TIPC_NLA_CON_NODE, peer_node))
 		goto msg_full;