commit 537f4146c53c95aac977852b371bafb9c6755ee1
author Arvind Yadav <arvind.yadav.cs@gmail.com> Tue Mar 06 15:35:43 2018 +0530
committer Tejun Heo <tj@kernel.org> Tue Mar 13 13:26:03 2018 -0700
tree b9efb4fd1da5c35febeef6dd3f9e21ac824d810e
parent fc6eabbbf8ef99efed778dd5afabc83c21dba585

workqueue: use put_device() instead of kfree()

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized in this function instead.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

kernel/workqueue.c

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index bb9a519..ccd1080 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -5337,7 +5337,7 @@ int workqueue_sysfs_register(struct workqueue_struct *wq)
 
 	ret = device_register(&wq_dev->dev);
 	if (ret) {
-		kfree(wq_dev);
+		put_device(&wq_dev->dev);
 		wq->wq_dev = NULL;
 		return ret;
 	}