tree 35ac5251f60c9a46b2cf4a2e5e12c30f05a48865
parent 32abb4788d3fff69fa242c7850e39ec1418df4f4
author Dan Carpenter <dan.carpenter@oracle.com> 1340788256 +0800
committer Bryan Wu <bryan.wu@canonical.com> 1343087555 +0800

leds-lp5523: BUG() in error handling in probe()

Inside the error handling in lp5523_init_led(), there is a place that
calls to led_classdev_unregister().  When we unregister the LED drivers,
it tries to set the brightness to OFF.  In this driver setting the
brightness is done through a work queue and the work queue hasn't been
initialized yet.

The result is that we trigger a WARN_ON() in the __queue_work().

The fix is to move the INIT_WORK() in front of the call to
lp5523_init_led().

Matt Renzelmann found this using a bug finding tool.

Reported-by: Matt Renzelmann <mjr@cs.wisc.edu>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>