tree 315fd16e3c18cfdde4a7ea9c4ca2f0b37ed9cbdd
parent 7928b2cbe55b2a410a0f5c1f154610059c57b1b2
author Chen-Yu Tsai <wens@csie.org> 1518872704 +0800
committer Maxime Ripard <maxime.ripard@bootlin.com> 1519027190 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlqKg/YACgkQ0rTAlCFN
 r3TVqQ/+IiREy9lAP4dTPSlxdJjT7DM1gbLwSsIknfSvJ3Oyw9GwTJ4jHItjZX/p
 sMleaPXxzNjgDgNQx2t3/Zcvvs76rK5gdN69nbpABYvk3+t9G2rROv8qjzb9cPfb
 zYsx1mMldfMFI7Fb8WJi1KLQuzYPH1JY9Hu8L/gjxKaDPJuGE/p05kCxVqWMPWG2
 cA15iBEtU2M0EK1HIDqeuZkaCyNt7m5YMQutmAOruhgyfgYEXirX5mbxnqItuS1Z
 7P1P4we43f6dHxZOpnarUV4EBDL8sx3TJrSQJjNIsEIvtEe5oK6Y3nqTch01rIeT
 CAd/GlQSyUnUtpGZBhjFO+tUWJP2HBmVgkqsym5RxC8zFpcnug9Z/zaoFfGSYVHy
 wr75K6rcjcEhIn9aYOtC/ziwS4sPAWu3wMH5628yVmYk0TKdCcnvHgNA/DV6WEfO
 ffIlWLhXa3DCj+TAnxPiShf2xoxGD+WRsHJDorhQY6byt59pIUK3kTwUG5Y5tPar
 sDFkg+wNkL/egLgq8ej2NmiiHH5bOiwzhlhmh/P3m7+iaalt0EI+7OxEPfwF9TsL
 wOeshxPyPjvvC1cevYQkLJtzMGkt+X0mD5Rcnl/MtGgA1CPlybMZ1015jaQYNVrz
 o+5/ahuMqI3HUb6VV4XYgm/qedMw65Od/7V8zJmcPYWMjaLHo+c=
 =n+XP
 -----END PGP SIGNATURE-----

clk: sunxi-ng: a31: Fix CLK_OUT_* clock ops

When support for the A31/A31s CCU was first added, the clock ops for
the CLK_OUT_* clocks was set to the wrong type. The clocks are MP-type,
but the ops was set for div (M) clocks. This went unnoticed until now.
This was because while they are different clocks, their data structures
aligned in a way that ccu_div_ops would access the second ccu_div_internal
and ccu_mux_internal structures, which were valid, if not incorrect.

Furthermore, the use of these CLK_OUT_* was for feeding a precise 32.768
kHz clock signal to the WiFi chip. This was achievable by using the parent
with the same clock rate and no divider. So the incorrect divider setting
did not affect this usage.

Commit 946797aa3f08 ("clk: sunxi-ng: Support fixed post-dividers on MP
style clocks") added a new field to the ccu_mp structure, which broke
the aforementioned alignment. Now the system crashes as div_ops tries
to look up a nonexistent table.

Reported-by: Philipp Rossak <embed3d@gmail.com>
Tested-by: Philipp Rossak <embed3d@gmail.com>
Fixes: c6e6c96d8fa6 ("clk: sunxi-ng: Add A31/A31s clocks")
Cc: <stable@vger.kernel.org>
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>