tree f9971f3e874dcf07c7ed8d2e77dd433395446548
parent d134c5ff71c7f2320fc7997f2fbbdedf0c76889a
author Maxime Ripard <maxime@cerno.tech> 1637142326 +0100
committer Maxime Ripard <maxime@cerno.tech> 1638195480 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYaThGgAKCRDj7w1vZxhR
 xa9gAQD7sNdeOza6uy3LHX6wTG6wACOLqeDMtO7AQRqoyW12VQEAwJjNiyhNUsME
 92YCGF020+WK5EiA7PddwcAeg0FDgQA=
 =i5hD
 -----END PGP SIGNATURE-----

drm/vc4: kms: Don't duplicate pending commit

Our HVS global state, when duplicated, will also copy the pointer to the
drm_crtc_commit (and increase the reference count) for each FIFO if the
pointer is not NULL.

However, our atomic_setup function will overwrite that pointer without
putting the reference back leading to a memory leak.

Since the commit is only relevant during the atomic commit process, it
doesn't make sense to duplicate the reference to the commit anyway.
Let's remove it.

Fixes: 9ec03d7f1ed3 ("drm/vc4: kms: Wait on previous FIFO users before a commit")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Tested-by: Jian-Hong Pan <jhp@endlessos.org>
Link: https://lore.kernel.org/r/20211117094527.146275-6-maxime@cerno.tech