commit 62d2a1940709198a522a43ff8be8b8f6b3654dec
author Chengguang Xu <cgxu519@gmx.com> Tue Aug 28 07:31:11 2018 +0800
committer Jens Axboe <axboe@kernel.dk> Mon Aug 27 19:16:06 2018 -0600
tree db9237beb8b83d40069a2090b263211dc792945e
parent 46cb52ad414ac829680d0bb8cc7090ac2b577ca7

block: remove unnecessary condition check

kmem_cache_destroy() can handle NULL pointer correctly, so there is
no need to check e->icq_cache before calling kmem_cache_destroy().

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

block/elevator.c

diff --git a/block/elevator.c b/block/elevator.c
index 5ea6e7d..6a06b5d 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -895,8 +895,7 @@ int elv_register(struct elevator_type *e)
 	spin_lock(&elv_list_lock);
 	if (elevator_find(e->elevator_name, e->uses_mq)) {
 		spin_unlock(&elv_list_lock);
-		if (e->icq_cache)
-			kmem_cache_destroy(e->icq_cache);
+		kmem_cache_destroy(e->icq_cache);
 		return -EBUSY;
 	}
 	list_add_tail(&e->list, &elv_list);