tree de1c395e91f0c6d03ccf06eb7de5da18fde946e7
parent 12f62a857c83b2efcbf8d9961aacd352bf81ad3d
author Dan Carpenter <dan.carpenter@oracle.com> 1636529975 +0300
committer Mark Brown <broonie@kernel.org> 1636741081 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGOr9kACgkQJNaLcl1U
 h9Du/wf9Fb5ugiLMinNq1xbkQCaWHcXfvJ9Qdmol7cuq1JCbDZTWgn98gwnZmKW9
 t7JsFpAX4XuBWYHS4MiDdExQZHzGRnMGJOKf4/zH78dur2d2skvR0Nz8CQQxNkem
 lYt1ahAUX8TlPTH0iyxk+HcI7/ax3W/1uKUuQMLrY82VOI7zcXczQrHc1O/K7AfI
 WQG3gved92f/QGzCp94OPMHTJ/t15BypZKS8Tk75265BnA+8xEdwecayiR88qn9M
 zvf7eWfg7LCaIpyhTEE/Suc8nfowY4FLjgQuCponNpWx3z6+skDLbDAaUOY+k9B5
 C5oYAqUyVPSG+vNVQ9xp2kFgFXE40A==
 =0Lg5
 -----END PGP SIGNATURE-----

spi: spi-geni-qcom: fix error handling in spi_geni_grab_gpi_chan()

This code has several issues:
1) It passes IS_ERR() to dev_err_probe() instead of PTR_ERR().
2) It always prints an error message, even when it succeeds.
3) The "if (ret < 0) {" conditions are never true.
4) If requesting "mas->tx" fails then it sets "mas->rx" to NULL but the
   intention was to set "mas->tx" to NULL.

Fixes: b59c122484ec ("spi: spi-geni-qcom: Add support for GPI dma")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/20211110073935.GA5176@kili
Signed-off-by: Mark Brown <broonie@kernel.org>