commit 6ea3c9d5b042edf14eac1e21af21c41f81f3491e
author Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Mon Aug 31 10:44:19 2015 -0700
committer David S. Miller <davem@davemloft.net> Mon Aug 31 12:45:09 2015 -0700
tree 313f0bacf4abc9db2c8063463335747f9cd76bec
parent f0fa6e529efbca3b97ab6286dbeb5910e33f6c53

mpls: fix mpls_net_init memory leak

Fix a memory leak in the mpls netns init function in case of failure. If
register_net_sysctl fails then we need to free the ctl_table.

Fixes: 7720c01f3f59 ("mpls: Add a sysctl to control the size of the mpls label table")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/mpls/af_mpls.c

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 8c5707d..bb185a2 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -1177,8 +1177,10 @@
 
 	table[0].data = net;
 	net->mpls.ctl = register_net_sysctl(net, "net/mpls", table);
-	if (net->mpls.ctl == NULL)
+	if (net->mpls.ctl == NULL) {
+		kfree(table);
 		return -ENOMEM;
+	}
 
 	return 0;
 }