commit 747125db6dcd8bcc21f13d013f6e6a2acade21ee
author Mika Westerberg <mika.westerberg@linux.intel.com> Mon Sep 16 17:03:03 2019 +0300
committer Mika Westerberg <mika.westerberg@linux.intel.com> Tue Oct 08 12:08:21 2019 +0300
tree d2db55ace2e534037ecc60867741fed91f48bf3b
parent 6f6709734274aef75058356e029d5e8f86d0d53b

thunderbolt: Drop unnecessary read when writing LC command in Ice Lake

The read is not needed as we overwrite the returned value in the next
line anyway so drop it.

Fixes: 3cdb9446a117 ("thunderbolt: Add support for Intel Ice Lake")
Reported-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

drivers/thunderbolt/nhi_ops.c

diff --git a/drivers/thunderbolt/nhi_ops.c b/drivers/thunderbolt/nhi_ops.c
index 61cd09c..6795851 100644
--- a/drivers/thunderbolt/nhi_ops.c
+++ b/drivers/thunderbolt/nhi_ops.c
@@ -80,7 +80,6 @@ static void icl_nhi_lc_mailbox_cmd(struct tb_nhi *nhi, enum icl_lc_mailbox_cmd c
 {
 	u32 data;
 
-	pci_read_config_dword(nhi->pdev, VS_CAP_19, &data);
 	data = (cmd << VS_CAP_19_CMD_SHIFT) & VS_CAP_19_CMD_MASK;
 	pci_write_config_dword(nhi->pdev, VS_CAP_19, data | VS_CAP_19_VALID);
 }