| commit | 75b3d5dc0846cfa54ea52d7d84215b761ecbf569 | [log] [tgz] |
|---|---|---|
| author | Justin Stitt <justinstitt@google.com> | Wed Sep 13 01:10:24 2023 +0000 |
| committer | Ira Weiny <ira.weiny@intel.com> | Wed Sep 27 10:33:46 2023 -0700 |
| tree | da4d6b0567d87b81228938d896792d46bd2075d7 | |
| parent | 6465e260f48790807eef06b583b38ca9789b6072 [diff] |
dax: refactor deprecated strncpy `strncpy` is deprecated for use on NUL-terminated destination strings [1]. We should prefer more robust and less ambiguous string interfaces. `dax_id->dev_name` is expected to be NUL-terminated and has been zero-allocated. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on the destination buffer. Moreover, due to `dax_id` being zero-allocated the padding behavior of `strncpy` is not needed and a simple 1:1 replacement of strncpy -> strscpy should suffice. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt <justinstitt@google.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Ira Weiny <ira.weiny@intel.com>