commit 7838f2ce36b6ab5c13ef20b1857e3bbd567f1759
author Thomas Graf <tgraf@redhat.com> Thu Dec 22 02:05:07 2011 +0000
committer David S. Miller <davem@davemloft.net> Thu Dec 22 22:34:56 2011 -0500
tree 4a84e53445817547adb299b25c54e613f76a8980
parent a13861a28b90541aa207532d237e7a940f1b1c7b

mqprio: Avoid panic if no options are provided

Userspace may not provide TCA_OPTIONS, in fact tc currently does
so not do so if no arguments are specified on the command line.
Return EINVAL instead of panicing.

Signed-off-by: Thomas Graf <tgraf@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/sched/sch_mqprio.c

diff --git a/net/sched/sch_mqprio.c b/net/sched/sch_mqprio.c
index f88256c..28de430 100644
--- a/net/sched/sch_mqprio.c
+++ b/net/sched/sch_mqprio.c
@@ -107,7 +107,7 @@
 	if (!netif_is_multiqueue(dev))
 		return -EOPNOTSUPP;
 
-	if (nla_len(opt) < sizeof(*qopt))
+	if (!opt || nla_len(opt) < sizeof(*qopt))
 		return -EINVAL;
 
 	qopt = nla_data(opt);