tree 5f27130752ba07e71bee19284e54d131e601445c
parent 0eb47346968f9b3852bbc56115f4feeecf23ea40
author Ben Hutchings <ben.hutchings@codethink.co.uk> 1480025423 +0000
committer Michal Marek <mmarek@suse.com> 1481455602 +0100

kconfig/nconf: Fix hang when editing symbol with a long prompt

Currently it is impossible to edit the value of a config symbol with a
prompt longer than (terminal width - 2) characters.  dialog_inputbox()
calculates a negative x-offset for the input window and newwin() fails
as this is invalid.  It also doesn't check for this failure, so it
busy-loops calling wgetch(NULL) which immediately returns -1.

The additions in the offset calculations also don't match the intended
size of the window.

Limit the window size and calculate the offset similarly to
show_scroll_win().

Cc: stable <stable@vger.kernel.org>
Fixes: 692d97c380c6 ("kconfig: new configuration interface (nconfig)")
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>