tree 2a539c1e9bda656c43231becb255a1aab9c03358
parent 4c3a14fbc05a09fc369fb68a86cdbf6f441a29f2
author Aswath Govindraju <a-govindraju@ti.com> 1599740784 +0530
committer Mark Brown <broonie@kernel.org> 1600733060 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQFHBAABCgAxFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9pP4QTHGJyb29uaWVA
 a2VybmVsLm9yZwAKCRAk1otyXVSH0C/dB/wJryW7jA3fV/pmQvM6bY2gIqaor5pE
 WZK7PqY5AuqR/VwDZ0ILxeygCX7LkJ/VUxz2H4rXKjFSKC8i1Kh+nrLlbzu1toha
 6IsJvqO0GSz1bHTMiyxfJdgjfHya4MMee/T9jus5Hx1ScupVPzkGUlko+iKDQj++
 PCMiluUX+KJmvvI30F8PlV+8EapHELGlYjREFvFiA4Hx/2wflHYlhGr5VfyNR46D
 UE1d8+sOjwTi6ELJERPSsqpIdJyXu2OLM3JkQ2Mtttt3DPjCgg0YzaRTG+EY7LXw
 ij99/WZt4S6M96EgvNeU2qWSJG6wkNr+LW3HKe4ThEdchwW0nJD8uGPF
 =g0aX
 -----END PGP SIGNATURE-----

spi: omap2-mcspi: Improve performance waiting for CHSTAT

This reverts commit 13d515c796 (spi: omap2-mcspi: Switch to
readl_poll_timeout()).

The amount of time spent polling for the MCSPI_CHSTAT bits to be set on
AM335x-icev2 platform is less than 1us (about 0.6us) in most cases, with
or without using DMA. So, in most cases the function need not sleep.
Also, setting the sleep_usecs to zero would not be optimal here because
ktime_add_us() used in readl_poll_timeout() is slower compared to the
direct addition used after the revert. So, it is sub-optimal to use
readl_poll_timeout in this case.

When DMA is not enabled, this revert results in an increase of about 27%
in throughput and decrease of about 20% in CPU usage. However, the CPU
usage and throughput are almost the same when used with DMA.

Therefore, fix this by reverting the commit which switched to using
readl_poll_timeout().

Fixes: 13d515c796ad ("spi: omap2-mcspi: Switch to readl_poll_timeout()")
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Link: https://lore.kernel.org/r/20200910122624.8769-1-a-govindraju@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>