commit 7ed20e1ad521b5f5df61bf6559ae60738e393741
author Jesper Juhl <juhl-lkml@dif.dk> Sun May 01 08:59:14 2005 -0700
committer Linus Torvalds <torvalds@ppc970.osdl.org> Sun May 01 08:59:14 2005 -0700
tree 90931724e45eaedb3445314e8b94e78253642395
parent e5bdd883a189243541e7a132385580703b049102

[PATCH] convert that currently tests _NSIG directly to use valid_signal()

Convert most of the current code that uses _NSIG directly to instead use
valid_signal().  This avoids gcc -W warnings and off-by-one errors.

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

kernel/sys.c

diff --git a/kernel/sys.c b/kernel/sys.c
index 7f43d6e..f64e97c 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -25,6 +25,7 @@
 #include <linux/dcookies.h>
 #include <linux/suspend.h>
 #include <linux/tty.h>
+#include <linux/signal.h>
 
 #include <linux/compat.h>
 #include <linux/syscalls.h>
@@ -1637,7 +1638,7 @@
 	switch (option) {
 		case PR_SET_PDEATHSIG:
 			sig = arg2;
-			if (sig < 0 || sig > _NSIG) {
+			if (!valid_signal(sig)) {
 				error = -EINVAL;
 				break;
 			}