commit 82a442d239695a242c4d584464c9606322cd02aa
author Alex Elder <elder@inktank.com> Fri May 31 17:40:44 2013 -0500
committer Sage Weil <sage@inktank.com> Wed Jul 03 15:32:41 2013 -0700
tree 50ce1f9db9ecede73a92fc6ce1680e340495fee1
parent 751cc0e3cfabdda87c4c21519253c6751e97a8d4

rbd: protect against concurrent unmaps

Make sure two concurrent unmap operations on the same rbd device
won't collide, by only proceeding with the removal and cleanup of a
device if is not already underway.

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

drivers/block/rbd.c

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 9eead487..305c740 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -5137,6 +5137,7 @@
 	struct list_head *tmp;
 	int dev_id;
 	unsigned long ul;
+	bool already = false;
 	int ret;
 
 	ret = strict_strtoul(buf, 10, &ul);
@@ -5164,11 +5165,12 @@
 		if (rbd_dev->open_count)
 			ret = -EBUSY;
 		else
-			set_bit(RBD_DEV_FLAG_REMOVING, &rbd_dev->flags);
+			already = test_and_set_bit(RBD_DEV_FLAG_REMOVING,
+							&rbd_dev->flags);
 		spin_unlock_irq(&rbd_dev->lock);
 	}
 	spin_unlock(&rbd_dev_list_lock);
-	if (ret < 0)
+	if (ret < 0 || already)
 		goto done;
 
 	rbd_bus_del_dev(rbd_dev);