commit 890c98e3746fa8705cc9c70979e64360cf2d8a31
author Axel Lin <axel.lin@gmail.com> Mon Oct 31 11:00:06 2011 +0800
committer Samuel Ortiz <sameo@linux.intel.com> Tue Dec 20 18:50:55 2011 +0100
tree 456c4a8104035dbcac651b4183ee33e17aad2a1e
parent 9ad33ba51a1ac29ba3cf90d95e4b7f7eba278f6c

mfd: Set adp5520 bits if new value is different from the old one

Current code checks if all the bit_mask bits are all zero is wrong.
We need to write new value if the bit mask fields of new value is
not equal to old value.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

drivers/mfd/adp5520.c

diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
index f1d8848..8d816cc 100644
--- a/drivers/mfd/adp5520.c
+++ b/drivers/mfd/adp5520.c
@@ -109,7 +109,7 @@
 
 	ret = __adp5520_read(chip->client, reg, &reg_val);
 
-	if (!ret && ((reg_val & bit_mask) == 0)) {
+	if (!ret && ((reg_val & bit_mask) != bit_mask)) {
 		reg_val |= bit_mask;
 		ret = __adp5520_write(chip->client, reg, reg_val);
 	}