commit 89f2df438b20f2176fcc8fc92201a708f0d3659b
author Johan Hovold <johan@hovoldconsulting.com> Thu Apr 21 11:43:36 2016 +0200
committer Greg Kroah-Hartman <gregkh@google.com> Thu Apr 21 20:19:33 2016 +0900
tree 4125f5a975f80a48a101084a77677f4718377145
parent 2437f1c6b582d1d676c08b6069859c11266c69da

greybus: svc: keep error messages uniform

All SVC error messages, except for a few recently added ones, place the
errno last after a colon (:). Let's at least try to be consistent
within the svc code.

Note that this format also allows for more concise messages without risk
for ambiguity.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

drivers/staging/greybus/svc.c

diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c
index 1791dcc..ff89da6 100644
--- a/drivers/staging/greybus/svc.c
+++ b/drivers/staging/greybus/svc.c
@@ -109,7 +109,7 @@
 				GB_SVC_TYPE_PWRMON_RAIL_COUNT_GET, NULL, 0,
 				&response, sizeof(response));
 	if (ret) {
-		dev_err(&svc->dev, "failed to get rail count (%d)\n", ret);
+		dev_err(&svc->dev, "failed to get rail count: %d\n", ret);
 		return ret;
 	}
 
@@ -128,7 +128,7 @@
 				GB_SVC_TYPE_PWRMON_RAIL_NAMES_GET, NULL, 0,
 				response, bufsize);
 	if (ret) {
-		dev_err(&svc->dev, "failed to get rail names (%d)\n", ret);
+		dev_err(&svc->dev, "failed to get rail names: %d\n", ret);
 		return ret;
 	}
 
@@ -149,7 +149,7 @@
 				&request, sizeof(request),
 				&response, sizeof(response));
 	if (ret) {
-		dev_err(&svc->dev, "failed to get rail sample (%d)\n", ret);
+		dev_err(&svc->dev, "failed to get rail sample: %d\n", ret);
 		return ret;
 	}
 
@@ -187,7 +187,7 @@
 				&request, sizeof(request),
 				&response, sizeof(response));
 	if (ret) {
-		dev_err(&svc->dev, "failed to get intf sample (%d)\n", ret);
+		dev_err(&svc->dev, "failed to get intf sample: %d\n", ret);
 		return ret;
 	}
 
@@ -479,8 +479,8 @@
 				       GB_SVC_PWRMON_TYPE_VOL, &value);
 	if (ret) {
 		dev_err(&svc->dev,
-			"failed to get voltage sample ret=%d id=%d\n",
-			ret, pwrmon_rails->id);
+			"failed to get voltage sample %u: %d\n",
+			pwrmon_rails->id, ret);
 		return ret;
 	}
 
@@ -502,8 +502,8 @@
 				       GB_SVC_PWRMON_TYPE_CURR, &value);
 	if (ret) {
 		dev_err(&svc->dev,
-			"failed to get current sample ret=%d id=%d\n",
-			ret, pwrmon_rails->id);
+			"failed to get current sample %u: %d\n",
+			pwrmon_rails->id, ret);
 		return ret;
 	}
 
@@ -524,8 +524,8 @@
 	ret = gb_svc_pwrmon_sample_get(svc, pwrmon_rails->id,
 				       GB_SVC_PWRMON_TYPE_PWR, &value);
 	if (ret) {
-		dev_err(&svc->dev, "failed to get power sample ret=%d id=%d\n",
-			ret, pwrmon_rails->id);
+		dev_err(&svc->dev, "failed to get power sample %u: %d\n",
+			pwrmon_rails->id, ret);
 		return ret;
 	}