commit 9918f230969bdaf3df012b77abcbcd4cdb0ab221
author Eric Sesterhenn <snakebyte@gmx.de> Tue Sep 26 23:26:38 2006 -0700
committer David S. Miller <davem@sunset.davemloft.net> Thu Sep 28 18:01:23 2006 -0700
tree 8cad5227f352a2a0756b2978339eff4b0a5ba0cb
parent 753ed90d92009260616f6402aafa7ee47e03b162

[RTNETLINK]: Possible dereference in net/core/rtnetlink.c

another possible dereference spotted by coverity (#cid 1390).
if the nlmsg_parse() call fails, we goto errout, where we call
dev_put(), with dev still initialized to NULL.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

net/core/rtnetlink.c

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index d8e25e0..221e403 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -562,7 +562,7 @@
 
 	err = nlmsg_parse(nlh, sizeof(*ifm), tb, IFLA_MAX, ifla_policy);
 	if (err < 0)
-		goto errout;
+		return err;
 
 	ifm = nlmsg_data(nlh);
 	if (ifm->ifi_index >= 0) {