commit 9980c6209ebc2a02eb3ca51a4fae1e17f645c868
author Roel Kluin <roel.kluin@gmail.com> Sun Dec 27 22:26:47 2009 +0100
committer Takashi Iwai <tiwai@suse.de> Mon Dec 28 12:14:39 2009 +0100
tree 38e7bf98aeb252c18260ed8ed83a0c45b5061be9
parent dfb12eeb0f04b37e5eb3858864d074af4ecd2ac7

ALSA: test off by one in setsamplerate()

With `while (i++ < MAX_WRITE_RETRY)' i reaches MAX_WRITE_RETRY + 1 after the loop

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

sound/pci/riptide/riptide.c

diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
index b5ca02e..e66ef2b 100644
--- a/sound/pci/riptide/riptide.c
+++ b/sound/pci/riptide/riptide.c
@@ -1058,7 +1058,7 @@
 				 rptr.retwords[2] != M &&
 				 rptr.retwords[3] != N &&
 				 i++ < MAX_WRITE_RETRY);
-			if (i == MAX_WRITE_RETRY) {
+			if (i > MAX_WRITE_RETRY) {
 				snd_printdd("sent samplerate %d: %d failed\n",
 					    *intdec, rate);
 				return -EIO;