tree 2eeb675c127afb5b92646f7a27ad434438018994
parent 7d54dc6876b83d6bb75b8f7e865b7b9051056d22
author Jesper Juhl <jesper.juhl@gmail.com> 1194821869 +0100
committer Vlad Yasevich <vladislav.yasevich@hp.com> 1194880404 -0500

Fix memory leak in discard case of sctp_sf_abort_violation()

In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak
the storage allocated for 'abort' by returning from the function
without using or freeing it. This happens in case
"sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)" is true and we jump to
the 'discard' label.
Spotted by the Coverity checker.

The simple fix is to simply move the creation of the "abort chunk"
to after the possible jump to the 'discard' label. This way we don't
even have to allocate the memory at all in the problem case.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>