commit 9bea3f29fc626e190f012c4ad5f8a9e9a2f26cf6
author Florin Malita <fmalita@gmail.com> Wed May 23 13:57:45 2007 -0700
committer Linus Torvalds <torvalds@woody.linux-foundation.org> Wed May 23 20:14:12 2007 -0700
tree 156a6c3cb913aef5bf8244e6333802950f8132b8
parent 6087b2dab2c914268b1a50882edbbad82bfefd29

spi: potential memleak in spidev_ioctl

'ioc' should be deallocated if __copy_from_user fails (found by Coverity
- CID 1644).

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

drivers/spi/spidev.c

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index bcfef04..d04242a 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -364,6 +364,7 @@
 			break;
 		}
 		if (__copy_from_user(ioc, (void __user *)arg, tmp)) {
+			kfree(ioc);
 			retval = -EFAULT;
 			break;
 		}