commit 9d577b6a31a53a19d3b0fe414d645a61ef201846
author David Howells <dhowells@redhat.com> Thu May 10 22:22:19 2007 -0700
committer Linus Torvalds <torvalds@woody.linux-foundation.org> Fri May 11 08:29:32 2007 -0700
tree 3e2523ac386e16eb0b125f3933b9ebfbd03aed65
parent 9393e1dc8e394bd59217178b26b2476dc43e8667

AFS: fix interminable loop in afs_write_back_from_locked_page()

Following bug was uncovered by compiling with '-W' flag:

  CC [M]  fs/afs/write.o
fs/afs/write.c: In function ‘afs_write_back_from_locked_page’:
fs/afs/write.c:398: warning: comparison of unsigned expression >= 0 is always true

Loop variable 'n' is unsigned, so wraps around happily as far as I can
see. Trival fix attached (compile tested only).

Signed-off-by: Mika Kukkonen <mikukkon@iki.fi>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

fs/afs/write.c

diff --git a/fs/afs/write.c b/fs/afs/write.c
index 67ae4db..28f3751 100644
--- a/fs/afs/write.c
+++ b/fs/afs/write.c
@@ -395,8 +395,9 @@
 		if (n == 0)
 			goto no_more;
 		if (pages[0]->index != start) {
-			for (n--; n >= 0; n--)
-				put_page(pages[n]);
+			do {
+				put_page(pages[--n]);
+			} while (n > 0);
 			goto no_more;
 		}