tree 0290805d3594d770da3937da7fa68841c1e294ac
parent cd43045c2de60f40a0aea49bfb252a2eafe58f8c
author Sage Weil <sage@inktank.com> 1341946414 -0700
committer Sage Weil <sage@inktank.com> 1343665792 -0700

libceph: fix messenger retry

In ancient times, the messenger could both initiate and accept connections.
An artifact if that was data structures to store/process an incoming
ceph_msg_connect request and send an outgoing ceph_msg_connect_reply.
Sadly, the negotiation code was referencing those structures and ignoring
important information (like the peer's connect_seq) from the correct ones.

Among other things, this fixes tight reconnect loops where the server sends
RETRY_SESSION and we (the client) retries with the same connect_seq as last
time.  This bug pretty easily triggered by injecting socket failures on the
MDS and running some fs workload like workunits/direct_io/test_sync_io.

Signed-off-by: Sage Weil <sage@inktank.com>