tree f6980f4599da0a64b9670f6111b4fccf318d0c66
parent 4a46fdba449a5cd890271df5a9e23927d519ed00
author Jia-Ju Bai <baijiaju1990@gmail.com> 1564493931 +0100
committer David Howells <dhowells@redhat.com> 1564493931 +0100

fs: afs: Fix a possible null-pointer dereference in afs_put_read()

In afs_read_dir(), there is an if statement on line 255 to check whether
req->pages is NULL:
	if (!req->pages)
		goto error;

If req->pages is NULL, afs_put_read() on line 337 is executed.
In afs_put_read(), req->pages[i] is used on line 195.
Thus, a possible null-pointer dereference may occur in this case.

To fix this possible bug, an if statement is added in afs_put_read() to
check req->pages.

This bug is found by a static analysis tool STCheck written by us.

Fixes: f3ddee8dc4e2 ("afs: Fix directory handling")
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>