commit a8aaa9958eea2420e13d5a00c3fae934e0a3889e
author Thomas Graf <tgraf@suug.ch> Sat Nov 05 21:14:14 2005 +0100
committer Thomas Graf <tgr@axs.localdomain> Sat Nov 05 22:02:26 2005 +0100
tree 1e85c385c7ce81afdf8bb7203df1ce56cd404892
parent 6639607ed9deaed9ab3a1cc588f0288891ece2ac

[PKT_SCHED]: GRED: Report out-of-bound DPs as illegal

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

net/sched/sch_gred.c

diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
index fdc20ce..b04b07f 100644
--- a/net/sched/sch_gred.c
+++ b/net/sched/sch_gred.c
@@ -451,12 +451,9 @@
 			return -EINVAL;
 
 	ctl = RTA_DATA(tb[TCA_GRED_PARMS-1]);
-	if (ctl->DP > MAX_DPs-1 ) {
-		/* misbehaving is punished! Put in the default drop probability */
-		DPRINTK("\nGRED: DP %u not in  the proper range fixed. New DP "
-			"set to default at %d\n",ctl->DP,table->def);
-		ctl->DP=table->def;
-	}
+
+	if (ctl->DP >= table->DPs)
+		return -EINVAL;
 	
 	if (table->tab[ctl->DP] == NULL) {
 		table->tab[ctl->DP]=kmalloc(sizeof(struct gred_sched_data),