commit aa6555622cdf443f0b001352fdc3afb6e7bce20d
author Dan Carpenter <dan.carpenter@oracle.com> Fri Oct 02 10:47:29 2015 +0300
committer Marcel Holtmann <marcel@holtmann.org> Fri Oct 02 23:34:37 2015 +0200
tree a6d47a68f7ae87ff8c31efe1dc95ea3120b627ea
parent 5f509239eccc9d118d3474a22e78b3da1ceefe02

nl802154: Missing return in nl802154_add_llsec_key()

There was a missing return here so it meant that often
ieee802154_llsec_parse_key_id() was not called.

Fixes: a26c5fd7622d ('nl802154: add support for security layer')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

net/ieee802154/nl802154.c

diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index 1e9e865..16ef0d9 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -1534,6 +1534,7 @@
 
 	if (!attrs[NL802154_KEY_ATTR_USAGE_FRAMES] ||
 	    !attrs[NL802154_KEY_ATTR_BYTES])
+		return -EINVAL;
 
 	if (ieee802154_llsec_parse_key_id(attrs[NL802154_KEY_ATTR_ID], &id) < 0)
 		return -ENOBUFS;