commit ad8d6a02d685ecf046c369d72285a5e69adaf66e
author DongDongJu <commisori28@gmail.com> Fri Mar 20 15:01:32 2020 +0900
committer Jaegeuk Kim <jaegeuk@kernel.org> Mon Mar 30 20:46:23 2020 -0700
tree 991eeb86b5b95374a30e2849cea37fbaf94c1672
parent 530e07042002f8c2893bab83d63e10f2750a4d50

f2fs: delete DIO read lock

This lock can be a contention with multi 4k random read IO with single inode.

example) fio --output=test --name=test --numjobs=60 --filename=/media/samsung960pro/file_test --rw=randread --bs=4k
 --direct=1 --time_based --runtime=7 --ioengine=libaio --iodepth=256 --group_reporting --size=10G

With this commit, it remove that possible lock contention.

Signed-off-by: Dongjoo Seo <commisori28@gmail.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

fs/f2fs/data.c

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index dbde309..326e634 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3453,7 +3453,8 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
 	err = __blockdev_direct_IO(iocb, inode, inode->i_sb->s_bdev,
 			iter, rw == WRITE ? get_data_block_dio_write :
 			get_data_block_dio, NULL, f2fs_dio_submit_bio,
-			DIO_LOCKING | DIO_SKIP_HOLES);
+			rw == WRITE ? DIO_LOCKING | DIO_SKIP_HOLES :
+			DIO_SKIP_HOLES);
 
 	if (do_opu)
 		up_read(&fi->i_gc_rwsem[READ]);