commit b2f10148ec1eae7d63dd6a1a56afdf93a27daa74
author Andy Shevchenko <andriy.shevchenko@linux.intel.com> Mon Jun 05 20:05:53 2023 +0300
committer Kees Cook <keescook@chromium.org> Mon Jun 05 15:31:12 2023 -0700
tree 59afb19b3127ae8d2f8dddd75d6a3c2de3c4c362
parent d01a77afd6bef1b3a2ed15e8ca6887ca7da0cddc

kobject: Use return value of strreplace()

Since strreplace() returns the pointer to the string itself,
we may use it directly in the code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230605170553.7835-4-andriy.shevchenko@linux.intel.com

lib/kobject.c

diff --git a/lib/kobject.c b/lib/kobject.c
index f79a434..16d530f 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -281,8 +281,7 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
 		kfree_const(s);
 		if (!t)
 			return -ENOMEM;
-		strreplace(t, '/', '!');
-		s = t;
+		s = strreplace(t, '/', '!');
 	}
 	kfree_const(kobj->name);
 	kobj->name = s;