tree 2264d2685b4de8bd3807e80bdafac468265acf5e
parent 18558cae0272f8fd9647e69d3fec1565a7949865
author Stefan Hajnoczi <stefanha@redhat.com> 1455821754 +0000
committer J. Bruce Fields <bfields@redhat.com> 1456251616 -0500

sunrpc/cache: fix off-by-one in qword_get()

The qword_get() function NUL-terminates its output buffer.  If the input
string is in hex format \xXXXX... and the same length as the output
buffer, there is an off-by-one:

  int qword_get(char **bpp, char *dest, int bufsize)
  {
      ...
      while (len < bufsize) {
          ...
          *dest++ = (h << 4) | l;
          len++;
      }
      ...
      *dest = '\0';
      return len;
  }

This patch ensures the NUL terminator doesn't fall outside the output
buffer.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>