commit bdacd1b426db83ac8ecf21aef1848120ffe53c07
author Rob Herring <robh@kernel.org> Tue Oct 11 13:41:03 2016 -0500
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> Mon Oct 31 09:15:22 2016 -0600
tree 10f8726e0c46e066c0e20961467907e1c9c6c034
parent c5f0627488be996e833038bdba01e45698ddaa26

driver core: fix smatch warning on dev->bus check

Commit d42a09802174 (driver core: skip removal test for non-removable
drivers) introduced a smatch warning:

drivers/base/dd.c:386 really_probe()
         warn: variable dereferenced before check 'dev->bus' (see line 373)

Fix the warning by removing the dev->bus NULL check. dev->bus will never
be NULL, so the check was unnecessary.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/base/dd.c

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 8937a7a..d76cd97 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -384,7 +384,7 @@ static int really_probe(struct device *dev, struct device_driver *drv)
 	if (test_remove) {
 		test_remove = false;
 
-		if (dev->bus && dev->bus->remove)
+		if (dev->bus->remove)
 			dev->bus->remove(dev);
 		else if (drv->remove)
 			drv->remove(dev);