commit | bf4a35e9201d30b63a8d276797d6ecfaa596ccd3 | [log] [tgz] |
---|---|---|
author | Azeem Shaikh <azeemshaikh38@gmail.com> | Tue May 23 02:14:51 2023 +0000 |
committer | Lee Jones <lee@kernel.org> | Thu May 25 12:31:55 2023 +0100 |
tree | af0018bee1b00a3870c9fd007cf4c83deb443d73 | |
parent | d6e3896b7c22278c6f4a9b166211fdddf1c86c3a [diff] |
leds: Replace all non-returning strlcpy with strscpy strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230523021451.2406362-1-azeemshaikh38@gmail.com Signed-off-by: Lee Jones <lee@kernel.org>