tree 1e1a36691f42ed7448f27f71a9ca9445e88ab5f1
parent 065825402c058f4a123ddc53dbbe864cc5caaf64
author Eric Dumazet <eric.dumazet@gmail.com> 1296065282 +0000
committer David S. Miller <davem@davemloft.net> 1296169376 -0800

net: fix dev_seq_next()

Commit c6d14c84566d (net: Introduce for_each_netdev_rcu() iterator)
added a race in dev_seq_next().

The rcu_dereference() call should be done _before_ testing the end of
list, or we might return a wrong net_device if a concurrent thread
changes net_device list under us.

Note : discovered thanks to a sparse warning :

net/core/dev.c:3919:9: error: incompatible types in comparison expression
(different address spaces)

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>