commit ce3c869283739379134e1a90c37dd1a30b5f31b7
author Nicolas Kaiser <nikai@nikai.net> Fri Mar 04 13:49:41 2011 +0000
committer David S. Miller <davem@davemloft.net> Mon Mar 07 15:57:58 2011 -0800
tree 781b387b2bf46d494084a080334c7eb4084fbacf
parent b3ca9b02b00704053a38bfe4c31dbbb9c13595d0

drivers/net/macvtap: fix error check

'len' is unsigned of type size_t and can't be negative.

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

drivers/net/macvtap.c

diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 5933621..fc27a99 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -528,8 +528,9 @@
 		vnet_hdr_len = q->vnet_hdr_sz;
 
 		err = -EINVAL;
-		if ((len -= vnet_hdr_len) < 0)
+		if (len < vnet_hdr_len)
 			goto err;
+		len -= vnet_hdr_len;
 
 		err = memcpy_fromiovecend((void *)&vnet_hdr, iv, 0,
 					   sizeof(vnet_hdr));